[all-commits] [llvm/llvm-project] 589ce5: [DebugInfo] Move constructor homing case in should...

Amy Huang via All-commits all-commits at lists.llvm.org
Mon Aug 24 20:18:31 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 589ce5f7050dd83fd3f7dbc182ea0fb051ece994
      https://github.com/llvm/llvm-project/commit/589ce5f7050dd83fd3f7dbc182ea0fb051ece994
  Author: Amy Huang <akhuang at google.com>
  Date:   2020-08-24 (Mon, 24 Aug 2020)

  Changed paths:
    M clang/lib/CodeGen/CGDebugInfo.cpp
    M clang/test/CodeGenCXX/debug-info-template-explicit-specialization.cpp

  Log Message:
  -----------
  [DebugInfo] Move constructor homing case in shouldOmitDefinition.

For some reason the ctor homing case was before the template
specialization case, and could have returned false too early.
I moved the code out into a separate function to avoid this.

Also added a run line to the template specialization test. I guess
all the -debug-info-kind=limited tests should still pass with =constructor,
but it's probably unnecessary to test for all of those.

Differential Revision: https://reviews.llvm.org/D86491




More information about the All-commits mailing list