[all-commits] [llvm/llvm-project] 93b255: [LLDB] Fix how ValueObjectVariable handles DW_AT_c...

[Shafik Yaghmour via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 93b255142bb7025f62cf83dd5b7d3b04aab5445b
      https://github.com/llvm/llvm-project/commit/93b255142bb7025f62cf83dd5b7d3b04aab5445b
  Author: shafik <syaghmour at apple.com>
  Date:   2020-08-24 (Mon, 24 Aug 2020)

  Changed paths:
    M lldb/source/Core/ValueObjectVariable.cpp
    A lldb/test/Shell/SymbolFile/DWARF/DW_AT_const_value.s

  Log Message:
  -----------
  [LLDB] Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

In some cases when we have a DW_AT_const_value and the data can be found in the
DWARFExpression then ValueObjectVariable does not handle it properly and we end
up with an extracting data from value failed error.

The test is a very stripped down assembly file since reproducing this relies on the results of compiling with -O1 which may not be stable over time.

Differential Revision: https://reviews.llvm.org/D86311