[all-commits] [llvm/llvm-project] 68bae3: [llvm-libtool-darwin] Add support for -V option

[Shoaib Meenai via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 68bae34c65b30ad3fe01555b4cf3020266cfec85
      https://github.com/llvm/llvm-project/commit/68bae34c65b30ad3fe01555b4cf3020266cfec85
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-08-24 (Mon, 24 Aug 2020)

  Changed paths:
    M llvm/test/tools/llvm-libtool-darwin/invalid-input-output-args.test
    M llvm/test/tools/llvm-libtool-darwin/missing-library-type.test
    A llvm/test/tools/llvm-libtool-darwin/version.test
    M llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp

  Log Message:
  -----------
  [llvm-libtool-darwin] Add support for -V option

The -V option in cctools' libtool prints out the version number and
performs any specified operation. Add this option to LLVM's version.
cctools is more forgiving of invalid command lines when -V is specified,
but I think it's better to give errors instead of silently producing no
output.

Unfortunately, when -V is present, options that would otherwise be
required aren't anymore, so we need to perform some manual argument
validation.

Reviewed By: alexshap

Differential Revision: https://reviews.llvm.org/D86359


  Commit: 26c1d689ae4cd24d228df1c35a2067fa970c52cc
      https://github.com/llvm/llvm-project/commit/26c1d689ae4cd24d228df1c35a2067fa970c52cc
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-08-24 (Mon, 24 Aug 2020)

  Changed paths:
    M compiler-rt/cmake/Modules/UseLibtool.cmake

  Log Message:
  -----------
  [compiler-rt] Disable ranlib when using libtool

libtool already produces a table of contents, and ranlib just gives
spurious errors because it doesn't understand universal binaries.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D86365


  Commit: a7d8aabf298c66cf03f3298ab1addb82e895a6af
      https://github.com/llvm/llvm-project/commit/a7d8aabf298c66cf03f3298ab1addb82e895a6af
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-08-24 (Mon, 24 Aug 2020)

  Changed paths:
    M llvm/runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Remove TOOLCHAIN_TOOLS specialization

{builtin,runtime}_register_target passes a TOOLCHAIN_TOOLS list, whereas
{builtin,runtime}_default_target does notl. The explicit TOOLCHAIN_TOOLS
list matches what LLVMExternalProjectUtils would have set anyway,
barring some target-specific adjustments, and those target-specific
adjustments seem valuable, so let's drop the explicit TOOLCHAIN_TOOLS
list and let LLVMExternalProjectUtils take care of it.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D86366


  Commit: 2c80e2fe51b685f5663ad6f76c9c05c75d7582c4
      https://github.com/llvm/llvm-project/commit/2c80e2fe51b685f5663ad6f76c9c05c75d7582c4
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2020-08-24 (Mon, 24 Aug 2020)

  Changed paths:
    M compiler-rt/CMakeLists.txt
    M compiler-rt/lib/builtins/CMakeLists.txt
    M llvm/cmake/modules/LLVMExternalProjectUtils.cmake

  Log Message:
  -----------
  [runtimes] Use llvm-libtool-darwin for runtimes build

It's full featured now and we can use it for the runtimes build instead
of relying on an external libtool, which means the CMAKE_HOST_APPLE
restriction serves no purpose either now. Restrict llvm-lipo to Darwin
targets while I'm here, since it's only needed there.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D86367


Compare: https://github.com/llvm/llvm-project/compare/47b0262d3f82...2c80e2fe51b6