[all-commits] [llvm/llvm-project] 44ee9d: Revert D85812 "[coroutine] should disable inline b...

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon Aug 24 11:41:26 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 44ee9d070adee1aed105f90d88b30b8802d90d35
      https://github.com/llvm/llvm-project/commit/44ee9d070adee1aed105f90d88b30b8802d90d35
  Author: Fangrui Song <i at maskray.me>
  Date:   2020-08-24 (Mon, 24 Aug 2020)

  Changed paths:
    M llvm/include/llvm/Transforms/Coroutines.h
    M llvm/lib/Transforms/Coroutines/CoroInternal.h
    M llvm/lib/Transforms/IPO/AlwaysInliner.cpp
    M llvm/lib/Transforms/IPO/SampleProfile.cpp
    R llvm/test/Transforms/Coroutines/Inputs/sample.text.prof
    R llvm/test/Transforms/Coroutines/coro-inline.ll

  Log Message:
  -----------
  Revert D85812 "[coroutine] should disable inline before calling coro split"

This reverts commit 2e43acfed89b1903de473f682c65878bdebc395a.

LLVMCoroutines (the library which contains Coroutines.h) depends on LLVMipo (the
library which contains SampleProfile.cpp). It is inappropriate for
SampleProfile.cpp to depent on Coroutines.h (circular dependency).

The test inverted dependencies as well:
llvm/test/Transforms/Coroutines/coro-inline.ll uses -sample-profile.




More information about the All-commits mailing list