[all-commits] [llvm/llvm-project] 910931: [lldb] Forcefully complete a type when adding type...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9109311356cc9e74818dd7450020d9b85d2f8125
      https://github.com/llvm/llvm-project/commit/9109311356cc9e74818dd7450020d9b85d2f8125
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-08-20 (Thu, 20 Aug 2020)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
    M lldb/test/Shell/SymbolFile/DWARF/DW_AT_declaration-with-children.s

  Log Message:
  -----------
  [lldb] Forcefully complete a type when adding typedefs

This is very similar to D85968, only more elusive to since we were not
adding the typedef type to the relevant DeclContext until D86140, which
meant that the DeclContext was populated (and the relevant assertion
hit) only after importing the type into the expression ast in a
particular way.

I haven't checked whether this situation can be hit in the gmodules
case, but my money is on "yes".

Differential Revision: https://reviews.llvm.org/D86216