[all-commits] [llvm/llvm-project] ef8992: Re-apply "[DebugInfo] Emit DW_OP_implicit_value fo...

Sourabh Singh Tomar via All-commits all-commits at lists.llvm.org
Wed Aug 19 13:10:20 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ef8992b9f0189005e0d9e09bd0967301bd7a7cc6
      https://github.com/llvm/llvm-project/commit/ef8992b9f0189005e0d9e09bd0967301bd7a7cc6
  Author: Sourabh Singh Tomar <SourabhSingh.Tomar at amd.com>
  Date:   2020-08-20 (Thu, 20 Aug 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
    M llvm/test/DebugInfo/X86/float_const_loclist.ll
    A llvm/test/DebugInfo/X86/implicit_value-double.ll
    A llvm/test/DebugInfo/X86/implicit_value-float.ll

  Log Message:
  -----------
  Re-apply "[DebugInfo] Emit DW_OP_implicit_value for Floating point constants"

This patch was reverted in 7c182663a857fc87 due to some failures
observed on PCC based machines. Failures were due to Endianness issue and
long double representation issues.

Patch is revised to address Endianness issue. Furthermore, support
for emission of `DW_OP_implicit_value` for `long double` has been removed
(since it was unclean at the moment). Planning to handle this in
a clean way soon!

For more context, please refer to following review link.

Reviewed By: aprantl

Differential Revision: https://reviews.llvm.org/D83560




More information about the All-commits mailing list