[all-commits] [llvm/llvm-project] 8e4acb: [CMake] Fix OCaml build failure because of absolut...
Petr Hosek via All-commits
all-commits at lists.llvm.org
Wed Aug 19 10:38:47 PDT 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 8e4acb82f71ad4effec8895b8fc957189ce95933
https://github.com/llvm/llvm-project/commit/8e4acb82f71ad4effec8895b8fc957189ce95933
Author: Petr Hosek <phosek at google.com>
Date: 2020-08-19 (Wed, 19 Aug 2020)
Changed paths:
M llvm/lib/Support/CMakeLists.txt
Log Message:
-----------
[CMake] Fix OCaml build failure because of absolute path in system libs
D85820 introduced a full path in the LLVM_SYSTEM_LIBS property of the
LLVMSupport target, which made the OCaml bindings fail to build, since
they use -l [system_lib] flags for every lib in LLVM_SYSTEM_LIBS, which
cannot work with absolute paths.
This patch solves the issue in a similar vain as ZLIB does it: it adds
the full library path to imported_libs, and adds a stripped down version
without directories, lib prefix and lib suffix to system_libs
In the future we should probably make some changes to LLVM_SYSTEM_LIBS,
since both zlib and ncurses do not necessarily have to be system libs
anymore due to the find_package / find_library bits introduced in
D85820 and D79219.
Patch By: haampie
Differential Revision: https://reviews.llvm.org/D86134
More information about the All-commits
mailing list