[all-commits] [llvm/llvm-project] d73633: [lldb] Add typedefs to the DeclContext they are cr...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d7363397c669f611e379988ea12fb428847fce61
      https://github.com/llvm/llvm-project/commit/d7363397c669f611e379988ea12fb428847fce61
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-08-19 (Wed, 19 Aug 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lldbtest.py
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
    M lldb/test/API/lang/cpp/typedef/TestCppTypedef.py
    M lldb/test/API/lang/cpp/typedef/main.cpp

  Log Message:
  -----------
  [lldb] Add typedefs to the DeclContext they are created in

TypeSystemClang::CreateTypedef was creating a typedef in the right
DeclContext, but it was not actually adding it as a child of the
context. The resulting inconsistent state meant that we would be unable
to reference the typedef from an expression directly, but we could use
them if they end up being pulled in by some previous subexpression
(because the ASTImporter will set up the correct links in the expression
ast).

This patch adds the typedef to the decl context it is created in.

Differential Revision: https://reviews.llvm.org/D86140


  Commit: 9cc2f13deeb30de3a2ce1854c36f6c0a8de86d6c
      https://github.com/llvm/llvm-project/commit/9cc2f13deeb30de3a2ce1854c36f6c0a8de86d6c
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-08-19 (Wed, 19 Aug 2020)

  Changed paths:
    M lldb/test/Shell/SymbolFile/DWARF/DW_AT_declaration-with-children.s

  Log Message:
  -----------
  [lldb] Clean up DW_AT_declaration-with-children.s test

Address some post-commit feedback on D85968.


Compare: https://github.com/llvm/llvm-project/compare/9fee2bad6d8a...9cc2f13deeb3