[all-commits] [llvm/llvm-project] 673dbe: [clang codegen] Use IR "align" attribute for stati...

Eli Friedman via All-commits all-commits at lists.llvm.org
Tue Aug 18 12:51:54 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 673dbe1b5eef09db39783c828a84f1213a47bad0
      https://github.com/llvm/llvm-project/commit/673dbe1b5eef09db39783c828a84f1213a47bad0
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M clang/lib/CodeGen/CGCall.cpp
    M clang/test/CodeGen/vla.c

  Log Message:
  -----------
  [clang codegen] Use IR "align" attribute for static array arguments.

Without the "align" attribute, marking the argument dereferenceable is
basically useless.  See also D80166.

Fixes https://bugs.llvm.org/show_bug.cgi?id=46876 .

Differential Revision: https://reviews.llvm.org/D84992


  Commit: bb18532399cf01c712e18f85ecb1cfb612d664ac
      https://github.com/llvm/llvm-project/commit/bb18532399cf01c712e18f85ecb1cfb612d664ac
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
    M llvm/test/CodeGen/AArch64/sve-intrinsics-stores.ll

  Log Message:
  -----------
  [AArch64][SVE] Allow llvm.aarch64.sve.st2/3/4 with vectors of pointers.

This isn't necessaary for ACLE, but could be useful in other situations.
And the change is simple.

Differential Revision: https://reviews.llvm.org/D85251


  Commit: be944c85f375c0faa36ee5c7ccbc79ff9a78a0d5
      https://github.com/llvm/llvm-project/commit/be944c85f375c0faa36ee5c7ccbc79ff9a78a0d5
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
    M llvm/lib/Target/AArch64/SVEInstrFormats.td
    M llvm/test/CodeGen/AArch64/llvm-ir-to-intrinsic.ll
    M llvm/test/CodeGen/AArch64/sve-gep.ll
    M llvm/test/CodeGen/AArch64/sve-int-arith.ll

  Log Message:
  -----------
  [AArch64][SVE] Add patterns for integer mla/mls.

We probably want to introduce pseudo-instructions at some point, like
we have for binary operations, but this seems okay for now.

One thing I'm not sure about is whether we should be doing this as a
DAGCombine instead of directly pattern-matching it. I don't see any big
downside to doing it this way, though.

Differential Revision: https://reviews.llvm.org/D85681


Compare: https://github.com/llvm/llvm-project/compare/6b1f9f2bd443...be944c85f375


More information about the All-commits mailing list