[all-commits] [llvm/llvm-project] 3ba777: AMDGPU/GlobalISel: Fix selection of s1/s16 G_[F]CO...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Aug 18 06:28:22 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3ba7777b94d887af594ba8d6c1378166bd361a20
      https://github.com/llvm/llvm-project/commit/3ba7777b94d887af594ba8d6c1378166bd361a20
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/divergent-control-flow.ll
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-and.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-constant.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fconstant.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-or.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-xor.mir

  Log Message:
  -----------
  AMDGPU/GlobalISel: Fix selection of s1/s16 G_[F]CONSTANT

The code to determine the value size was overcomplicated and only
correct in the case where the result register already had a register
class assigned. We can always take the size directly from the
register's type.


  Commit: 2f5f5febf3e4fa9bc80e8a8f63a99d3e6813c499
      https://github.com/llvm/llvm-project/commit/2f5f5febf3e4fa9bc80e8a8f63a99d3e6813c499
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-08-18 (Tue, 18 Aug 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
    A llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-amdgcn.groupstaticsize.mir
    M llvm/test/CodeGen/AMDGPU/llvm.amdgcn.groupstaticsize.ll

  Log Message:
  -----------
  AMDGPU/GlobalISel: Select llvm.amdgcn.groupstaticsize

Previously, it would successfully select and assert if not HSA or PAL
when expanding the pseudoinstruction. We don't need the
pseudoinstruction anymore since we know the total size after
legalization.


Compare: https://github.com/llvm/llvm-project/compare/740332b6cce3...2f5f5febf3e4


More information about the All-commits mailing list