[all-commits] [llvm/llvm-project] eed647: Reset PAL metadata when AMDGPU traget stream finishes

Steven Perron via All-commits all-commits at lists.llvm.org
Mon Aug 17 08:00:42 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: eed6476a8744179efe096c8d1fe6d53bf696962f
      https://github.com/llvm/llvm-project/commit/eed6476a8744179efe096c8d1fe6d53bf696962f
  Author: Steven Perron <stevenperron at google.com>
  Date:   2020-08-17 (Mon, 17 Aug 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.cpp
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.h

  Log Message:
  -----------
  Reset PAL metadata when AMDGPU traget stream finishes

If the same stream object is used for multiple compiles, the PAL metadata from eariler compilations will leak into later one.  See https://github.com/GPUOpen-Drivers/llpc/issues/882 for how this is happening in LLPC.

No tests were added because multiple compiles will have to happen using the same pass manager, and I do not see a setup for that on the LLVM side.  Let me know if there is a good way to test this.

Reviewed By: nhaehnle

Differential Revision: https://reviews.llvm.org/D85667




More information about the All-commits mailing list