[all-commits] [llvm/llvm-project] a49b05: [JITLink][MachO] Use correct symbol scope when N_P...

[lhames via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a49b05bb61f73eee3ebfa6c985c1d19356d383b5
      https://github.com/llvm/llvm-project/commit/a49b05bb61f73eee3ebfa6c985c1d19356d383b5
  Author: Lang Hames <lhames at gmail.com>
  Date:   2020-08-15 (Sat, 15 Aug 2020)

  Changed paths:
    M llvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.cpp
    A llvm/test/ExecutionEngine/JITLink/X86/Inputs/MachO_x86-64_was_private_extern.o
    A llvm/test/ExecutionEngine/JITLink/X86/MachO_x86-64_was_private_extern.test

  Log Message:
  -----------
  [JITLink][MachO] Use correct symbol scope when N_PEXT is set and N_EXT unset.

MachOLinkGraphBuilder has been treating these as hidden, but they should be
treated as local.

Symbols with N_PEXT set and N_EXT unset are produced when hidden symbols are
run through 'ld -r' without passing -keep_private_externs. They will show up
under 'nm -m' as "was private extern", hence the name of the test cases.

Testcase commited as relocatable object to ensure that the test suite doesn't
depend on having 'ld -r' available.