[all-commits] [llvm/llvm-project] 25bbce: [LLDB] Fix how ValueObjectChild handles bit-fields...

[Shafik Yaghmour via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 25bbceb047a3ce85394d510a16bd3fcfd69b8c75
      https://github.com/llvm/llvm-project/commit/25bbceb047a3ce85394d510a16bd3fcfd69b8c75
  Author: shafik <syaghmour at apple.com>
  Date:   2020-08-13 (Thu, 13 Aug 2020)

  Changed paths:
    M lldb/source/Core/ValueObjectChild.cpp
    A lldb/test/Shell/SymbolFile/DWARF/DW_AT_data_bit_offset-DW_OP_stack_value.s

  Log Message:
  -----------
  [LLDB] Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

When bit-field data was stored in a Scalar in ValueObjectChild during UpdateValue()
it was extracting the bit-field value. Later on in lldb_private::DumpDataExtractor(…)
we were again attempting to extract the bit-field. Which would then not obtain the
correct value. This will remove the extra extraction in UpdateValue().
We hit this specific case when values are passed in registers, which we could only
reproduce in an optimized build.

Differential Revision: https://reviews.llvm.org/D85376