[all-commits] [llvm/llvm-project] c224bc: Remove DialectHooks and introduce a Dialect Interf...

[Mehdi Amini via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c224bc71af4d190f913ac7784a4f475aab2f1cd7
      https://github.com/llvm/llvm-project/commit/c224bc71af4d190f913ac7784a4f475aab2f1cd7
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2020-08-13 (Thu, 13 Aug 2020)

  Changed paths:
    M mlir/include/mlir/IR/Dialect.h
    R mlir/include/mlir/IR/DialectHooks.h
    A mlir/include/mlir/Interfaces/DecodeAttributesInterfaces.h
    A mlir/include/mlir/Interfaces/FoldInterfaces.h
    M mlir/lib/IR/Attributes.cpp
    M mlir/lib/IR/Dialect.cpp
    M mlir/lib/IR/Operation.cpp

  Log Message:
  -----------
  Remove DialectHooks and introduce a Dialect Interfaces instead

These hooks were introduced before the Interfaces mechanism was available.

DialectExtractElementHook is unused and entirely removed. The
DialectConstantFoldHook is used a fallback in the
operation fold() method, and is replaced by a DialectInterface.
The DialectConstantDecodeHook is used for interpreting OpaqueAttribute
and should be revamped, but is replaced with an interface in 1:1 fashion
for now.

Differential Revision: https://reviews.llvm.org/D85595


  Commit: b28e3db88d053b94250562f837758dc8a92a0a0f
      https://github.com/llvm/llvm-project/commit/b28e3db88d053b94250562f837758dc8a92a0a0f
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2020-08-13 (Thu, 13 Aug 2020)

  Changed paths:
    M mlir/docs/Canonicalization.md
    M mlir/include/mlir/Interfaces/FoldInterfaces.h
    M mlir/include/mlir/Transforms/FoldUtils.h
    M mlir/lib/Transforms/Utils/FoldUtils.cpp
    M mlir/test/lib/Dialect/Test/TestDialect.cpp

  Log Message:
  -----------
  Merge OpFolderDialectInterface with DialectFoldInterface (NFC)

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D85823


Compare: https://github.com/llvm/llvm-project/compare/bd08e0cf1cb1...b28e3db88d05