[all-commits] [llvm/llvm-project] f5a252: [SanitizerCoverage] Use zeroext for cmp parameters...

Ilya Leoshkevich via All-commits all-commits at lists.llvm.org
Wed Aug 12 09:38:36 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f5a252ed681c155b1d6337309519ab27d5f3b450
      https://github.com/llvm/llvm-project/commit/f5a252ed681c155b1d6337309519ab27d5f3b450
  Author: Ilya Leoshkevich <iii at linux.ibm.com>
  Date:   2020-08-12 (Wed, 12 Aug 2020)

  Changed paths:
    M compiler-rt/test/fuzzer/swap-cmp.test
    M llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp
    M llvm/test/Instrumentation/SanitizerCoverage/cmp-tracing-api-x86_32.ll

  Log Message:
  -----------
  [SanitizerCoverage] Use zeroext for cmp parameters on all targets

Commit 9385aaa84851 ("[sancov] Fix PR33732") added zeroext to
__sanitizer_cov_trace(_const)?_cmp[1248] parameters for x86_64 only,
however, it is useful on other targets, in particular, on SystemZ: it
fixes swap-cmp.test.

Therefore, use it on all targets. This is safe: if target ABI does not
require zero extension for a particular parameter, zeroext is simply
ignored. A similar change has been implemeted as part of commit
3bc439bdff8b ("[MSan] Add instrumentation for SystemZ"), and there were
no problems with it.

Reviewed By: morehouse

Differential Revision: https://reviews.llvm.org/D85689




More information about the All-commits mailing list