[all-commits] [llvm/llvm-project] aa4bc1: Limit Max Vector alignment on COFF targets to 8192.

Erich Keane via All-commits all-commits at lists.llvm.org
Wed Aug 12 06:36:01 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: aa4bc1cb7978b87bdbdb75910da0abbd27889800
      https://github.com/llvm/llvm-project/commit/aa4bc1cb7978b87bdbdb75910da0abbd27889800
  Author: Erich Keane <erich.keane at intel.com>
  Date:   2020-08-12 (Wed, 12 Aug 2020)

  Changed paths:
    M clang/include/clang/Basic/TargetInfo.h
    M clang/lib/Basic/Targets/X86.h
    M clang/test/CodeGen/alignment.c

  Log Message:
  -----------
  Limit Max Vector alignment on COFF targets to 8192.

COFF targets have a max object alignment of 8192, so trying to create
one with a larger size results in an unreachable in WinCOFFObjectWriter.

For the reproducer I have uses thread local storage, however other
alignments are likely affected as well.

This patch sets the MaxVectorAlign for COFF to 8192.  Additionally,
though there is no longer a way to reproduce that I could find, it
correctly sets the MaxTLSAlign for COFF to that value as well, so that
if anyone comes up with a situation where this is true, it will cause an
error.

Differential Revision: https://reviews.llvm.org/D85543




More information about the All-commits mailing list