[all-commits] [llvm/llvm-project] 645dd1: [libTooling] Cleanup and reorder `RewriteRule.h`.

Yitzhak Mandelbaum via All-commits all-commits at lists.llvm.org
Tue Aug 11 09:36:35 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 645dd1b3bf8d976683c72b9faf501d6f0b16326e
      https://github.com/llvm/llvm-project/commit/645dd1b3bf8d976683c72b9faf501d6f0b16326e
  Author: Yitzhak Mandelbaum <yitzhakm at google.com>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M clang/include/clang/Tooling/Transformer/RewriteRule.h
    M clang/lib/Tooling/Transformer/RewriteRule.cpp

  Log Message:
  -----------
  [libTooling] Cleanup and reorder `RewriteRule.h`.

This patch lifts `RootID` out of the `RewriteRule` class so that constructs
(e.g. inline functions) can that refer to the root id don't need to depend on
the `RewriteRule` class.

With this dependency, the patch is able to collect all `ASTEdit` helper function
declarations together with the class declaration, before the introduction of the
`RewriteRule` class. In the process, we also adjust some of the comments.

This patch is essentially a NFC.

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D85733




More information about the All-commits mailing list