[all-commits] [llvm/llvm-project] dbc468: [split-file] Fix sys::fs::remove() on Solaris afte...

[Fangrui Song via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dbc468dc319953c86c2c564475f4939f66572810
      https://github.com/llvm/llvm-project/commit/dbc468dc319953c86c2c564475f4939f66572810
  Author: Fangrui Song <i at maskray.me>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M llvm/tools/split-file/split-file.cpp

  Log Message:
  -----------
  [split-file] Fix sys::fs::remove() on Solaris after D83834

where stdio.h ::remove() may set errno to EEXIST instead of ENOTEMPTY.

POSIX.1-2017 allows EEXIST for unlink() (which is called by remove()):

> [EEXIST] or [ENOTEMPTY]
> The flag parameter has the AT_REMOVEDIR bit set and the path argument names a directory that is not an empty directory, or there are hard links to the directory other than dot or a single entry in dot-dot.

Reviewed By: ro

Differential Revision: https://reviews.llvm.org/D85690