[all-commits] [llvm/llvm-project] bb91c9: [cmake] Make gtest macro definitions a part the li...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bb91c9fe7b62939fdb11ae42a31a5d5a61575ae7
      https://github.com/llvm/llvm-project/commit/bb91c9fe7b62939fdb11ae42a31a5d5a61575ae7
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M lldb/unittests/TestingSupport/Symbol/CMakeLists.txt
    M llvm/cmake/modules/AddLLVM.cmake
    M llvm/lib/Testing/Support/CMakeLists.txt
    M llvm/utils/unittest/CMakeLists.txt

  Log Message:
  -----------
  [cmake] Make gtest macro definitions a part the library interface

These definitions are needed by any file which uses gtest. Previously we
were adding them in the add_unittest function, but over time we've
accumulated libraries (which don't go through add_unittest) building on
gtest and this has resulted in proliferation of the definitions.

Making this a part of the library interface enables them to be managed
centrally. This follows a patch for -Wno-suggest-override (D84554) which
took a similar approach.

Differential Revision: https://reviews.llvm.org/D84748


  Commit: c3817728e7b6b367a8aa91f8cbbcbc229b10a998
      https://github.com/llvm/llvm-project/commit/c3817728e7b6b367a8aa91f8cbbcbc229b10a998
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M lld/MachO/Arch/X86_64.cpp

  Log Message:
  -----------
  [lld] s/dyn_cast/isa

Fixes some unused variable warnings with gcc.


Compare: https://github.com/llvm/llvm-project/compare/d7d172b4aae0...c3817728e7b6