[all-commits] [llvm/llvm-project] a73008: [DebugInfo] Refactor .debug_macro checks. NFCI

[David via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a73008c1aed2d712d9683aa2f01f8ce0096d21bc
      https://github.com/llvm/llvm-project/commit/a73008c1aed2d712d9683aa2f01f8ce0096d21bc
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h

  Log Message:
  -----------
  [DebugInfo] Refactor .debug_macro checks. NFCI

Move the Dwarf version checks that determine if the .debug_macro section
should be emitted, into a DwarfDebug member. This is a preparatory
refactoring for allowing the GNU .debug_macro extension, which is a
precursor to the DWARF 5 format, to be emitted by LLVM for earlier DWARF
versions.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D82971


  Commit: 2892ed6d0fa9545df8c2d846a1fdaa948c4571d9
      https://github.com/llvm/llvm-project/commit/2892ed6d0fa9545df8c2d846a1fdaa948c4571d9
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M llvm/include/llvm/BinaryFormat/Dwarf.def
    M llvm/include/llvm/BinaryFormat/Dwarf.h

  Log Message:
  -----------
  [DebugInfo] Introduce GNU macro extension entry encodings

This is a preparatory patch for allowing the GNU .debug_macro extension,
which is a precursor to the DWARF 5 format, to be emitted by LLVM for
earlier DWARF versions.

The entries share the same encoding and behavior as in DWARF5; there are
just more entries in the DWARF 5 format. Therefore, we could have used
those existing DWARF 5 entries, but I think that explicitly referring to
the GNU macro variants makes the code more clear.

The defines that this patch introduces can be found in GCC in the dwarf2.h header:
  https://gcc.gnu.org/git/?p=gcc.git;a=blob;
  f=include/dwarf2.h;
  h=0b6facfd4cf4c02320c7328114231b128ab42d5e;
  hb=dccbf1e2a6e544f71b4a5795f0c79015db019fc3#l425

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D82972


  Commit: 91bd9db2cdbc12176c3a058d407ef58ced30ea23
      https://github.com/llvm/llvm-project/commit/91bd9db2cdbc12176c3a058d407ef58ced30ea23
  Author: David Stenberg <david.stenberg at ericsson.com>
  Date:   2020-08-11 (Tue, 11 Aug 2020)

  Changed paths:
    M llvm/include/llvm/BinaryFormat/Dwarf.h
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
    M llvm/lib/BinaryFormat/Dwarf.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
    A llvm/test/DebugInfo/X86/debug-macro-gnu.s

  Log Message:
  -----------
  [DebugInfo] Allow GNU macro extension to be read

Allow the GNU .debug_macro extension to be parsed and printed by
llvm-dwarfdump. In an upcoming patch support will be added for emitting
that format also.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D82974


Compare: https://github.com/llvm/llvm-project/compare/a952fe236f99...91bd9db2cdbc