[all-commits] [llvm/llvm-project] e2d61a: Correctly set CompilingPCH in PrecompilePreambleAc...

Adam Czachorowski via All-commits all-commits at lists.llvm.org
Mon Aug 10 08:51:00 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e2d61ae5733316a14783b36c84b8e7681b0e3d59
      https://github.com/llvm/llvm-project/commit/e2d61ae5733316a14783b36c84b8e7681b0e3d59
  Author: Adam Czachorowski <adamcz at google.com>
  Date:   2020-08-10 (Mon, 10 Aug 2020)

  Changed paths:
    M clang-tools-extra/clangd/unittests/CMakeLists.txt
    A clang-tools-extra/clangd/unittests/ModulesTests.cpp
    M clang/lib/Frontend/PrecompiledPreamble.cpp
    M clang/unittests/Frontend/ASTUnitTest.cpp

  Log Message:
  -----------
  Correctly set CompilingPCH in PrecompilePreambleAction.

This fixes a crash bug in clangd when used with modules. ASTWriter would
end up writing references to submodules into the PCH file, but upon
reading the submodules would not exists and
HeaderFileInfoTrait::ReadData would crash.

Differential Revision: https://reviews.llvm.org/D85532




More information about the All-commits mailing list