[all-commits] [llvm/llvm-project] d3153b: [X86] Remove a DCI.isBeforeLegalize() call from co...

topperc via All-commits all-commits at lists.llvm.org
Sat Aug 8 14:19:57 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d3153b5ca29b80d73af449727ca557eb6ccbd973
      https://github.com/llvm/llvm-project/commit/d3153b5ca29b80d73af449727ca557eb6ccbd973
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-08-08 (Sat, 08 Aug 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Remove a DCI.isBeforeLegalize() call from combineVSelectWithAllOnesOrZeros.

This was blocking isTypeLegal call so that we could do a particular
transform on illegal types before type legalization. But the we
create a target specific node using that type. We shouldn't do
that if the type isn't legal. So I think we should just always
make sure the type is legal.

I suspect that in order to get the condition VT to not be a vector
of i1 we already completed type legalization anyway so this probably
doesn't matter much in practice.




More information about the All-commits mailing list