[all-commits] [llvm/llvm-project] 279922: [ELF] Change tombstone values to (.debug_ranges/.d...

[Fangrui Song via All-commits]

  Branch: refs/heads/release/11.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 279922f108c26fe09667ba2525ab18b4735b28b2
      https://github.com/llvm/llvm-project/commit/279922f108c26fe09667ba2525ab18b4735b28b2
  Author: Fangrui Song <maskray at google.com>
  Date:   2020-08-07 (Fri, 07 Aug 2020)

  Changed paths:
    M lld/ELF/InputSection.cpp
    M lld/test/ELF/dead-reloc-in-nonalloc.s
    M lld/test/ELF/debug-dead-reloc-32.s
    M lld/test/ELF/debug-dead-reloc-icf.s
    M lld/test/ELF/debug-dead-reloc-tls-arm.s
    M lld/test/ELF/debug-dead-reloc-tls.s
    M lld/test/ELF/debug-dead-reloc.s

  Log Message:
  -----------
  [ELF] Change tombstone values to (.debug_ranges/.debug_loc) 1 and (other .debug_*) 0

tl;dr See D81784 for the 'tombstone value' concept. This patch changes our behavior to be almost the same as GNU ld (except that we also use 1 for .debug_loc):

* .debug_ranges & .debug_loc: 1 (LLD<11: 0+addend; GNU ld uses 1 for .debug_ranges)
* .debug_*: 0 (LLD<11: 0+addend; GNU ld uses 0; future LLD: -1)

We make the tweaks because:

1) The new tombstone is novel and needs more time to be adopted by consumers before it's the default.
2) The old (gold) strategy had problems with zero-length functions - so rather than going back that, we're going to the GNU ld strategy which doesn't have that problem.
3) One slight tweak to (2) is to apply the .debug_ranges workaround to .debug_loc for the same reasons it applies to debug_ranges - to avoid terminating lists early.

-----

http://lists.llvm.org/pipermail/llvm-dev/2020-July/143482.html

The tombstone value -1 in .debug_line caused problems to lldb (fixed by D83957;
will be included in 11.0.0) and breakpad (fixed by
https://crrev.com/c/2321300). It may potentially affects other DWARF consumers.

For .debug_ranges & .debug_loc: 1, an argument preferring 1 (GNU ld for .debug_ranges) over -2 is that:
```
{-1, -2}    <<< base address selection entry
{0, length} <<< address range
```
may create a situation where low_pc is greater than high_pc. So we use
1, the GNU ld behavior for .debug_ranges

For other .debug_* sections, there haven't been many reports. One issue is that
bloaty (src/dwarf.cc) can incorrectly count address ranges in .debug_ranges . To
reduce similar disruption, this patch changes the tombstone values to be similar to GNU ld.

This does mean another behavior change to the default trunk behavior. Sorry
about it. The default trunk behavior will be similar to release/11.x while we work on a transition plan for LLD users.

Reviewed By: dblaikie, echristo

Differential Revision: https://reviews.llvm.org/D84825

(cherry picked from commit 004be4037e1e9c6092323c5c9268acb3ecf9176c)