[all-commits] [llvm/llvm-project] 05df9c: Correctly detect legacy iOS simulator Mach-O objec...

[adrian-prantl via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 05df9cc70367a60cb34bee773389ab2522984f8b
      https://github.com/llvm/llvm-project/commit/05df9cc70367a60cb34bee773389ab2522984f8b
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-08-06 (Thu, 06 Aug 2020)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
    M lldb/source/Utility/ArchSpec.cpp
    M lldb/test/API/macosx/simulator/TestSimulatorPlatform.py
    M lldb/unittests/Utility/ArchSpecTest.cpp

  Log Message:
  -----------
  Correctly detect legacy iOS simulator Mach-O objectfiles

The code in ObjectFileMachO didn't disambiguate between ios and
ios-simulator object files for Mach-O objects using the legacy
ambiguous LC_VERSION_MIN load commands. This used to not matter before
taught ArchSpec that ios and ios-simulator are no longer compatible.

rdar://problem/66545307

Differential Revision: https://reviews.llvm.org/D85358