[all-commits] [llvm/llvm-project] 0215ae: [X86] Remove incomplete custom handling of i128 sd...

topperc via All-commits all-commits at lists.llvm.org
Wed Aug 5 23:01:54 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0215ae9735376ab527f32a68b2fcc9eb540f48c8
      https://github.com/llvm/llvm-project/commit/0215ae9735376ab527f32a68b2fcc9eb540f48c8
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-08-05 (Wed, 05 Aug 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Remove incomplete custom handling of i128 sdivrem/udivrem on Windows.

We need to have special handling of i128 div/rem on Windows due
to a weird calling convention needed for the libcall. There was
also some code that made it look like we do the same for sdivrem/udiv,
but the code didn't account for multiple return values of those
functions so couldn't possibly work. I think this code never
triggers because we don't have libcall names defined for those
functions by default so DAGCombine never creates DIVREM nodes.




More information about the All-commits mailing list