[all-commits] [llvm/llvm-project] 6d2d73: [flang] Fix compilation warning in check-directive...

Tim Keith via All-commits all-commits at lists.llvm.org
Wed Aug 5 18:04:01 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6d2d73059fda5a63f2b34a9482acc0445e0956a4
      https://github.com/llvm/llvm-project/commit/6d2d73059fda5a63f2b34a9482acc0445e0956a4
  Author: Tim Keith <tkeith at nvidia.com>
  Date:   2020-08-05 (Wed, 05 Aug 2020)

  Changed paths:
    M flang/lib/Semantics/check-directive-structure.h

  Log Message:
  -----------
  [flang] Fix compilation warning in check-directive-structure.h

Clang 9 gets the following warning after revision `D85104`.
```
../../flang/lib/Semantics/check-directive-structure.h:36:7: error: 'Fortran::semantics::DirectiveStructureChecker<llvm::omp::Directive, llvm::omp::Clause, Fortran::parser::OmpClause, 77>' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
```

The fix is the make the destructor virtual. Neither it nor the
constructor need to be public, so make them protected.

Differential Revision: https://reviews.llvm.org/D85383




More information about the All-commits mailing list