[all-commits] [llvm/llvm-project] 030ddc: [ELF] Allow sections after a non-SHF_ALLOC section...

[Fangrui Song via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 030ddc0a0bb9e2b25319eb681d520a9cee32b761
      https://github.com/llvm/llvm-project/commit/030ddc0a0bb9e2b25319eb681d520a9cee32b761
  Author: Fangrui Song <i at maskray.me>
  Date:   2020-08-05 (Wed, 05 Aug 2020)

  Changed paths:
    M lld/ELF/LinkerScript.cpp
    M lld/ELF/Writer.cpp
    M lld/test/ELF/linkerscript/compress-debug-sections-custom.s
    M lld/test/ELF/linkerscript/sections.s
    M lld/test/ELF/linkerscript/symbols-non-alloc.test

  Log Message:
  -----------
  [ELF] Allow sections after a non-SHF_ALLOC section to be covered by PT_LOAD

GNU ld allows sections after a non-SHF_ALLOC section to be covered by PT_LOAD
(PR37607) and assigns addresses to non-SHF_ALLOC output sections (similar to
SHF_ALLOC NOBITS sections. The location counter is not advanced).

This patch tries to fix PR37607 (remove a special case in
`Writer<ELFT>::createPhdrs`). To make the created PT_LOAD meaningful, we cannot
reset dot to 0 for a middle non-SHF_ALLOC output section. This results in
removal of two special cases in LinkerScript::assignOffsets. Non-SHF_ALLOC
non-orphan sections can have non-zero addresses like in GNU ld.

The zero address rule for non-SHF_ALLOC sections is weakened to apply to orphan
only. This results in a special case in createSection and findOrphanPos, respectively.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D85100