[all-commits] [llvm/llvm-project] e31cfc: Fix -Wconstant-conversion warning with explicit cast

David Blaikie via All-commits all-commits at lists.llvm.org
Tue Aug 4 10:43:44 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e31cfc4cd3e393300002e9c519787c96e3b67bab
      https://github.com/llvm/llvm-project/commit/e31cfc4cd3e393300002e9c519787c96e3b67bab
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-08-04 (Tue, 04 Aug 2020)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64FrameLowering.cpp

  Log Message:
  -----------
  Fix -Wconstant-conversion warning with explicit cast

Introduced by fd6584a22043b254a323635c142b28ce80ae5b5b

Following similar use of casts in AsmParser.cpp, for instance - ideally
this type would use unsigned chars as they're more representative of raw
data and don't get confused around implementation defined choices of
char's signedness, but this is what it is & the signed/unsigned
conversions are (so far as I understand) safe/bit preserving in this
usage and what's intended, given the API design here.




More information about the All-commits mailing list