[all-commits] [llvm/llvm-project] d10074: Fix update_cc_test_checks.py --llvm-bin after D78478

Alexander Richardson via All-commits all-commits at lists.llvm.org
Mon Aug 3 03:23:31 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d1007478f19d3ff19a2ecd5ecb04b467933041e6
      https://github.com/llvm/llvm-project/commit/d1007478f19d3ff19a2ecd5ecb04b467933041e6
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-08-03 (Mon, 03 Aug 2020)

  Changed paths:
    M llvm/utils/UpdateTestChecks/common.py
    M llvm/utils/update_cc_test_checks.py

  Log Message:
  -----------
  Fix update_cc_test_checks.py --llvm-bin after D78478

Not passing --clang would result in a python exception after this change:
(TypeError: expected str, bytes or os.PathLike object, not NoneType)
because the --clang argument default was only being populated in the
initial argument parsing pass but not later on.
Fix this by adding an argparse callback to set the default values.

Reviewed By: vitalybuka, MaskRay

Differential Revision: https://reviews.llvm.org/D84511




More information about the All-commits mailing list