[all-commits] [llvm/llvm-project] 7e3279: [llvm-readobj] - Don't call `unwrapOrErr` in `find...
Georgii Rymar via All-commits
all-commits at lists.llvm.org
Mon Aug 3 02:41:37 PDT 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 7e32797552c69155676e45ec7d39f948779daa92
https://github.com/llvm/llvm-project/commit/7e32797552c69155676e45ec7d39f948779daa92
Author: Georgii Rymar <grimar at accesssoftek.com>
Date: 2020-08-03 (Mon, 03 Aug 2020)
Changed paths:
M llvm/test/tools/llvm-readobj/ELF/mips-abiflags.test
M llvm/test/tools/llvm-readobj/ELF/mips-got.test
M llvm/test/tools/llvm-readobj/ELF/mips-options-sec.test
M llvm/test/tools/llvm-readobj/ELF/mips-reginfo.test
M llvm/tools/llvm-readobj/ELFDumper.cpp
Log Message:
-----------
[llvm-readobj] - Don't call `unwrapOrErr` in `findSectionByName`.
We have a `findSectionByName` helper that tries to find a section
by it name. It is used in a few places, but never tested.
I'd like to reuse this helper for a different place.
For this, I've changed it to return Expected<> and now it
doesn't use `unwrapOrErr` anymore. It also now a member of
Dumper class and might report warnings.
Differential revision: https://reviews.llvm.org/D84651
More information about the All-commits
mailing list