[all-commits] [llvm/llvm-project] ff756f: [compiler-rt][Darwin] Fix linker errors for check-...

Julian Lettner via All-commits all-commits at lists.llvm.org
Fri Jul 31 16:45:38 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ff756f5231cc2ee9457129404e78420fa2791c7b
      https://github.com/llvm/llvm-project/commit/ff756f5231cc2ee9457129404e78420fa2791c7b
  Author: Julian Lettner <julian.lettner at apple.com>
  Date:   2020-07-31 (Fri, 31 Jul 2020)

  Changed paths:
    M compiler-rt/cmake/Modules/CompilerRTCompile.cmake

  Log Message:
  -----------
  [compiler-rt][Darwin] Fix linker errors for check-asan

A recent change broke `ninja check-asan` on Darwin by causing an error
during linking of ASan unit tests [1].

Move the addition of `-ObjC` compiler flag outside of the new
`if(COMPILER_RT_STANDALONE_BUILD)` block.  It doesn't add any global
flags (e.g, `${CMAKE_CXX_FLAGS}`) and the decision to add is based
solely on source paths (`${source_rpath}`).

[1] 8b2fcc42b895, https://reviews.llvm.org/D84466

Differential Revision: https://reviews.llvm.org/D85057




More information about the All-commits mailing list