[all-commits] [llvm/llvm-project] d275da: [libc++] Fix eager generator expression in DefineL...

[Louis Dionne via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d275da17e4f0a17615b24c352aab0d34f647bfa7
      https://github.com/llvm/llvm-project/commit/d275da17e4f0a17615b24c352aab0d34f647bfa7
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-07-31 (Fri, 31 Jul 2020)

  Changed paths:
    M libcxx/cmake/Modules/DefineLinkerScript.cmake

  Log Message:
  -----------
  [libc++] Fix eager generator expression in DefineLinkerScript

As explained in https://gitlab.kitware.com/cmake/cmake/-/issues/21045,
both branches of an $<IF> generator expression are evaluated eagerly
by CMake. As a result, if the non-selected branch contains an invalid
generator expression (such as getting the OUTPUT_NAME property of a
non-existent target), a hard error will occur.

This failed builds using the cxxrt ABI library, which doesn't create
a CMake target currently.