[all-commits] [llvm/llvm-project] 03116a: [OpenMP] Use weak attribute in interface only for ...

[Joachim via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 03116a9f8c2fc98577e153083aaf9b6a701ab8f9
      https://github.com/llvm/llvm-project/commit/03116a9f8c2fc98577e153083aaf9b6a701ab8f9
  Author: Joachim Protze <protze at itc.rwth-aachen.de>
  Date:   2020-07-31 (Fri, 31 Jul 2020)

  Changed paths:
    M openmp/runtime/src/kmp_ftn_entry.h
    M openmp/runtime/src/kmp_os.h
    M openmp/runtime/src/ompt-specific.cpp

  Log Message:
  -----------
  [OpenMP] Use weak attribute in interface only for static library

This is to address the issue reported at:
https://bugs.llvm.org/show_bug.cgi?id=46863

Since weak is meaningless for a shared library interface function, this patch
disables the attribute, when the OpenMP library is built as shared library.

ompt_start_tool is not an interface function, but a internally called function
possibly implemented by an OMPT tool.
This function needs to be weak if possible to allow overwriting ompt_start_tool
with a function implementation built into the application.

Differential Revision: https://reviews.llvm.org/D84871