[all-commits] [llvm/llvm-project] abf546: debguserver's type sniffer to only treat .app thin...

[Jason Molenda via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: abf546dd4f8326b821244b67eaa79ada7757d877
      https://github.com/llvm/llvm-project/commit/abf546dd4f8326b821244b67eaa79ada7757d877
  Author: Jason Molenda <jason at molenda.com>
  Date:   2020-07-30 (Thu, 30 Jul 2020)

  Changed paths:
    M lldb/tools/debugserver/source/debugserver.cpp

  Log Message:
  -----------
  debguserver's type sniffer to only treat .app things that end in .app

On an iOS device, if debugserver is left to figure out how to launch
the binary provided, it looks at the filename to see if it contains
".app" and asks FrontBoard to launch it.  However, if this is actually
a command line app with the characters ".app" in the name, it would
end up trying to launch that via the FrontBoard calls even though it
needed to be launched via posix_spawn.  For instance, a command line
program called com.application.tester.

Jim suggested this patch where we only send binaries that end in ".app"
to FrontBoard.

Often debugsever is invoked with a --launch command line argument to
specify the launch method, and none of this code is hit in that
instance.

<rdar://problem/65297100>