[all-commits] [llvm/llvm-project] 1745ba: [Analyzer] Remove inclusion of uniqueing decl from...

[Balázs Kéri via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1745ba41b196d80d8a6739dffcbb6f613d371f29
      https://github.com/llvm/llvm-project/commit/1745ba41b196d80d8a6739dffcbb6f613d371f29
  Author: Balázs Kéri <1.int32 at gmail.com>
  Date:   2020-07-30 (Thu, 30 Jul 2020)

  Changed paths:
    M clang/lib/Analysis/PathDiagnostic.cpp
    A clang/test/Analysis/report-uniqueing.cpp

  Log Message:
  -----------
  [Analyzer] Remove inclusion of uniqueing decl from diagnostic profile.

The uniqueing decl in PathDiagnostic is the declaration with the
uniqueing loc, as stated by documentation comments.
It is enough to include the uniqueing loc in the profile. It is possible
to have objects with different uniqueing decl but same location, at
least with templates. These belong to the same class and should have
same profile.

Reviewed By: vsavchenko, NoQ

Differential Revision: https://reviews.llvm.org/D84843