[all-commits] [llvm/llvm-project] 175974: [X86] Don't pass some many parameters to ParseMemO...

[topperc via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 17597442db159829dd167abb638b198ad0afc309
      https://github.com/llvm/llvm-project/commit/17597442db159829dd167abb638b198ad0afc309
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-07-29 (Wed, 29 Jul 2020)

  Changed paths:
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp

  Log Message:
  -----------
  [X86] Don't pass some many parameters to ParseMemOperand by reference.

Pointers and SMLocs are cheap to copy. Even though the function
modifies some of these the caller doesn't use them after the call.


  Commit: 07bb8240a0b2f4262764efb828b09650f24a03c5
      https://github.com/llvm/llvm-project/commit/07bb8240a0b2f4262764efb828b09650f24a03c5
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-07-29 (Wed, 29 Jul 2020)

  Changed paths:
    M llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp

  Log Message:
  -----------
  [X86] Pass the OperandVector to ParseMemOperand instead of returning the operand. NFCI

Continue the change made to ParseATTOperand to take the vector by
reference. Let ParseMemOperand add its memory operand to the
vector and just return true/false to indicate error.


Compare: https://github.com/llvm/llvm-project/compare/032ed39defc7...07bb8240a0b2