[all-commits] [llvm/llvm-project] 068808: AMDGPU: Don't assume call targets are registers

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Jul 28 17:46:24 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 068808d102846d551e683241d0b3b9607b3bdf8d
      https://github.com/llvm/llvm-project/commit/068808d102846d551e683241d0b3b9607b3bdf8d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-07-28 (Tue, 28 Jul 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
    M llvm/test/CodeGen/AMDGPU/call-constant.ll

  Log Message:
  -----------
  AMDGPU: Don't assume call targets are registers

GlobalISel let through a call to null, which would then fold into the
source operand like any other inline immediate. The SelectionDAG
lowering deletes calls to null and undef as a workaround from before
calls were supported. We should probably drop the special handling
case in the DAG lowering now, since the middle end optimizers delete
null calls anyway.




More information about the All-commits mailing list