[all-commits] [llvm/llvm-project] 4c6eeb: [lldb/AppleSimulator] Always provide a -simulator ...

[fredriss via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4c6eebf86a0734779cd20473cfcaa9d7c8899298
      https://github.com/llvm/llvm-project/commit/4c6eebf86a0734779cd20473cfcaa9d7c8899298
  Author: Fred Riss <friss at apple.com>
  Date:   2020-07-27 (Mon, 27 Jul 2020)

  Changed paths:
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
    M lldb/unittests/Platform/CMakeLists.txt
    A lldb/unittests/Platform/PlatformAppleSimulatorTest.cpp

  Log Message:
  -----------
  [lldb/AppleSimulator] Always provide a -simulator environment

Summary:
This commit is somewhat NFC-ish today as the environment of triples
is not considered when comparing s if one of them is
not set (I plan to change that).

We have made simulator triples unambiguous these days, but the
simulator platforms still advertise triples without the
environment. This wasn't an issue when the sims ran only on
a very different architecure than the real device, but this
has changed with Apple Silicon.

This patch simplifies the way GetSupportedArchitectureAtIndex
is implemented for the sim platforms and adds the environment.
It also trivially adds support for Apple Silicon to those
platforms.

Reviewers: aprantl

Subscribers: lldb-commits