[all-commits] [llvm/llvm-project] a52aea: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest...

[kepler-5 via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a52aea0ba624fcf46602bff8463b7b831e87ba55
      https://github.com/llvm/llvm-project/commit/a52aea0ba624fcf46602bff8463b7b831e87ba55
  Author: Logan Smith <logan.r.smith0 at gmail.com>
  Date:   2020-07-27 (Mon, 27 Jul 2020)

  Changed paths:
    M clang-tools-extra/clangd/unittests/CMakeLists.txt
    M clang-tools-extra/unittests/CMakeLists.txt
    M clang/unittests/CMakeLists.txt
    M lld/unittests/CMakeLists.txt
    M llvm/lib/Testing/Support/CMakeLists.txt
    M llvm/unittests/CMakeLists.txt
    M llvm/utils/unittest/CMakeLists.txt
    M mlir/unittests/CMakeLists.txt
    M polly/unittests/CMakeLists.txt

  Log Message:
  -----------
  Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

This cleans up several CMakeLists.txt's where -Wno-suggest-override was manually specified. These test targets now inherit this flag from the gtest target.

Some unittests CMakeLists.txt's, in particular Flang and LLDB, are not touched by this patch. Flang manually adds the gtest sources itself in some configurations, rather than linking to LLVM's gtest target, so this fix would be insufficient to cover those cases. Similarly, LLDB has subdirectories that manually add the gtest headers to their include path without linking to the gtest target, so those subdirectories still need -Wno-suggest-override to be manually specified to compile without warnings.

Differential Revision: https://reviews.llvm.org/D84554