[all-commits] [llvm/llvm-project] 974ffe: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in...

Kirill Bobyrev via All-commits all-commits at lists.llvm.org
Mon Jul 27 01:45:54 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 974ffee9ccd70703c6edb880ac4934a5dc12e56d
      https://github.com/llvm/llvm-project/commit/974ffee9ccd70703c6edb880ac4934a5dc12e56d
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2020-07-27 (Mon, 27 Jul 2020)

  Changed paths:
    M clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp

  Log Message:
  -----------
  [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

Summary:
When dereferencing Optional's it makes sense to use ASSERT_TRUE for better
test failures readability. Switch from EXPECT_TRUE to ASSERT_TRUE where
it is appropriate.

Reviewers: kadircet

Reviewed By: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D84535

Signed-off-by: Kirill Bobyrev <kbobyrev at google.com>




More information about the All-commits mailing list