[all-commits] [llvm/llvm-project] 0db293: [ASTImporter] Modify ImportDefiniton for ObjCInter...

[Shafik Yaghmour via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0db2934b0fa9e00ac98e2cb168adba96f6bcd0da
      https://github.com/llvm/llvm-project/commit/0db2934b0fa9e00ac98e2cb168adba96f6bcd0da
  Author: shafik <syaghmour at apple.com>
  Date:   2020-07-24 (Fri, 24 Jul 2020)

  Changed paths:
    M clang/lib/AST/ASTImporter.cpp
    M lldb/test/API/lang/objc/bitfield_ivars/TestBitfieldIvars.py

  Log Message:
  -----------
  [ASTImporter] Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

Once we start the definition of an ObjCInterfaceDecl we won't attempt to ImportDeclContext
later on. Unlike RecordDecl case which uses DefinitionCompleter to force completeDefinition
we don't seem to have a similar mechanism for ObjCInterfaceDecl.

This fix was needed due to a bug we see in LLDB expression parsing where an initial expression
cause an ObjCInterfaceDecl to be defined and subsequent expressions during import do not call
ImportDeclContext and we can end up in a situation where ivars are imported out of order and not all ivars are imported.

Differential Revision: https://reviews.llvm.org/D83972