[all-commits] [llvm/llvm-project] dfae71: GlobalISel: Fix maxScalarIf predicate check

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Jul 23 18:46:51 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dfae7174f8bb83f18490ba80ac44b4ed4bb29f66
      https://github.com/llvm/llvm-project/commit/dfae7174f8bb83f18490ba80ac44b4ed4bb29f66
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-07-23 (Thu, 23 Jul 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h

  Log Message:
  -----------
  GlobalISel: Fix maxScalarIf predicate check

The std::function itself was tested, not the result of the actual
query. It seems like there should be a warning for this. Inline the
check to avoid this.


  Commit: 8e62ffdef1c8e50cc0f108b1d67a37bcb6089279
      https://github.com/llvm/llvm-project/commit/8e62ffdef1c8e50cc0f108b1d67a37bcb6089279
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-07-23 (Thu, 23 Jul 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h

  Log Message:
  -----------
  GlobalISel: Drop original type pointeriness in minScalarSameAs

It is not useful to report WidenScalar for a pointer value, so always
report a scalar value with the target size. This allows using this to
clamp the scalar operand to the pointer size in operations like
G_PTR_ADD or G_PTRMASK.


  Commit: 891759db73f085df6af7bd343aa0cc0b5dccb572
      https://github.com/llvm/llvm-project/commit/891759db73f085df6af7bd343aa0cc0b5dccb572
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-07-23 (Thu, 23 Jul 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/LegalizerInfo.h
    M llvm/lib/CodeGen/GlobalISel/LegalizeMutations.cpp
    M llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-ptrmask.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-ptrmask.mir

  Log Message:
  -----------
  GlobalISel: Add scalarSameSizeAs LegalizeRule

Widen or narrow a type to a type with the same scalar size as
another. This can be used to force G_PTR_ADD/G_PTRMASK's scalar
operand to match the bitwidth of the pointer type. Use this to
disallow narrower types for G_PTRMASK.


Compare: https://github.com/llvm/llvm-project/compare/4637daa9905c...891759db73f0


More information about the All-commits mailing list