[all-commits] [llvm/llvm-project] 238bbd: Revert abd45154b "[Coverage] Add comment to skippe...

[Hans via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 238bbd48c5a5f84deca36e5df980241578f7c1df
      https://github.com/llvm/llvm-project/commit/238bbd48c5a5f84deca36e5df980241578f7c1df
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M clang/include/clang/Lex/Preprocessor.h
    M clang/lib/CodeGen/CodeGenAction.cpp
    M clang/lib/CodeGen/CoverageMappingGen.cpp
    M clang/lib/CodeGen/CoverageMappingGen.h
    M clang/lib/Lex/Preprocessor.cpp
    M clang/test/CoverageMapping/break.c
    M clang/test/CoverageMapping/builtinmacro.c
    M clang/test/CoverageMapping/classtemplate.cpp
    M clang/test/CoverageMapping/comment-in-macro.c
    M clang/test/CoverageMapping/continue.c
    M clang/test/CoverageMapping/coroutine.cpp
    M clang/test/CoverageMapping/deferred-region.cpp
    M clang/test/CoverageMapping/if.cpp
    M clang/test/CoverageMapping/includehell.cpp
    M clang/test/CoverageMapping/label.cpp
    M clang/test/CoverageMapping/logical.cpp
    M clang/test/CoverageMapping/loops.cpp
    M clang/test/CoverageMapping/macro-expressions.cpp
    M clang/test/CoverageMapping/macroparams2.c
    M clang/test/CoverageMapping/macros.c
    M clang/test/CoverageMapping/macroscopes.cpp
    M clang/test/CoverageMapping/moremacros.c
    M clang/test/CoverageMapping/objc.m
    M clang/test/CoverageMapping/pr32679.cpp
    M clang/test/CoverageMapping/preprocessor.c
    M clang/test/CoverageMapping/return.c
    M clang/test/CoverageMapping/switch.cpp
    M clang/test/CoverageMapping/switchmacro.c
    M clang/test/CoverageMapping/test.c
    M clang/test/CoverageMapping/trycatch.cpp
    M clang/test/CoverageMapping/unreachable-macro.c
    M clang/test/CoverageMapping/while.c
    M clang/test/lit.cfg.py
    M compiler-rt/test/profile/Inputs/instrprof-comdat.h
    R compiler-rt/test/profile/coverage_comments.cpp
    M compiler-rt/test/profile/instrprof-set-file-object-merging.c

  Log Message:
  -----------
  Revert abd45154b "[Coverage] Add comment to skipped regions"

This casued assertions during Chromium builds. See comment on the code review

> Bug filled here: https://bugs.llvm.org/show_bug.cgi?id=45757.
> Add comment to skipped regions so we don't track execution count for lines containing only comments.
>
> Differential Revision: https://reviews.llvm.org/D84208

This reverts commit abd45154bdb6b76c5b480455eacc8c75b08242aa and the
follow-up 87d725473380652bbe845fd2fbd9c0507a55172f.