[all-commits] [llvm/llvm-project] 066e20: [llvm-readelf/readobj] - Fix the behavior when a s...

[Georgii Rymar via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 066e209c9d5d8a2c9ff2d7feb5630cfc9616b38d
      https://github.com/llvm/llvm-project/commit/066e209c9d5d8a2c9ff2d7feb5630cfc9616b38d
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    R llvm/test/tools/llvm-readobj/ELF/broken-group.test
    M llvm/test/tools/llvm-readobj/ELF/groups.test
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [llvm-readelf/readobj] - Fix the behavior when a sections is included in two groups at the same time.

The current behavior was introduced by me in D37567 and it is a bit strange. It prints the
"Error: ...." message to the errs() manually and stops dumping the group section which has this error.
This behavior is consistent with GNU though, but it is very inconsistent with what the regular llvm-readelf
code usually does/prints, so I suggest to change the implementation:

1) Instead of printing "Error: ...." to errs() - just report a warning.
2) Try to continue dumping the section.
3) Merge broken-group.test to group.text.

This is what this patch does.

Differential revision: https://reviews.llvm.org/D84170