[all-commits] [llvm/llvm-project] 0881d0: [PDB][NativeSession] Clean up some things in Nativ...

[Amy Huang via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0881d0bed3aaac1f9769f2bac4852a83dd1fd8c5
      https://github.com/llvm/llvm-project/commit/0881d0bed3aaac1f9769f2bac4852a83dd1fd8c5
  Author: Amy Huang <akhuang at google.com>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M llvm/include/llvm/DebugInfo/PDB/Native/NativeFunctionSymbol.h
    M llvm/include/llvm/DebugInfo/PDB/Native/NativeLineNumber.h
    M llvm/include/llvm/DebugInfo/PDB/Native/NativePublicSymbol.h
    M llvm/include/llvm/DebugInfo/PDB/Native/SymbolCache.h
    M llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
    M llvm/lib/DebugInfo/PDB/Native/NativeLineNumber.cpp
    M llvm/lib/DebugInfo/PDB/Native/NativePublicSymbol.cpp
    M llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp
    M llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
    A llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
    R llvm/test/tools/llvm-symbolizer/pdb/pdb-native-columns.test
    R llvm/test/tools/llvm-symbolizer/pdb/pdb-native.test
    M llvm/test/tools/llvm-symbolizer/pdb/pdb.test

  Log Message:
  -----------
  [PDB][NativeSession] Clean up some things in NativeSession.

-Use the actual sect/offset to keep track of symbols in the cache so they don't get created multiple times with different addresses.
-Remove getSymTag from PDBFunctionSymbol/PDBPublicSymbol because it's already implemented in the base class
-Merge the symbolizer test files for DIA and native, since the tests are the same.
-Implement getCompilandId for NativeLineNumber

Reviewed By: amccarth

Differential Revision: https://reviews.llvm.org/D84208