[all-commits] [llvm/llvm-project] 4d75cc: More conservatively report status from LoopIdiomRe...

Jon Roelofs via All-commits all-commits at lists.llvm.org
Tue Jul 21 08:32:45 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4d75cc4b0a648ede4886fd98ce70d462f5d3994a
      https://github.com/llvm/llvm-project/commit/4d75cc4b0a648ede4886fd98ce70d462f5d3994a
  Author: Jon Roelofs <jonathan_roelofs at apple.com>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp

  Log Message:
  -----------
  More conservatively report status from LoopIdiomRecognize

Being "precise" here is getting us into trouble with one of the
EXPENSIVE_CHECKS buildbots, see [1].  Rather than reporting IR additions that
later get rolled back as "no change", instead we now conservatively report that
there was.

1: http://lists.llvm.org/pipermail/llvm-dev/2020-July/143509.html

Differential Revision: https://reviews.llvm.org/D84071


  Commit: dc09c65f638f177265f47d897469888cfa011041
      https://github.com/llvm/llvm-project/commit/dc09c65f638f177265f47d897469888cfa011041
  Author: Jon Roelofs <jonathan_roelofs at apple.com>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp

  Log Message:
  -----------
  LoopIdiomRecognize: use ExpandedValuesCleaner in another place

This is a necessary cleanup after having expanded a SCEV.

See: https://reviews.llvm.org/D84071#inline-774728

Differential Revision: https://reviews.llvm.org/D84174


Compare: https://github.com/llvm/llvm-project/compare/28da5759bd5a...dc09c65f638f


More information about the All-commits mailing list