[all-commits] [llvm/llvm-project] d4020e: [Windows] Fix limit on command line size

Serge Pavlov via All-commits all-commits at lists.llvm.org
Tue Jul 21 03:34:47 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d4020ef7c474b5e695d77aa100d7f68dc0c66b4e
      https://github.com/llvm/llvm-project/commit/d4020ef7c474b5e695d77aa100d7f68dc0c66b4e
  Author: Serge Pavlov <sepavloff at gmail.com>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M llvm/include/llvm/Support/Program.h
    M llvm/lib/Support/Windows/Program.inc
    M llvm/unittests/Support/CommandLineTest.cpp

  Log Message:
  -----------
  [Windows] Fix limit on command line size

Documentation on CreateProcessW states that maximal size of command line
is 32767 characters including ternimation null character. In the
function llvm::sys::commandLineFitsWithinSystemLimits this limit was set
to 32768. As a result if command line was exactly 32768 characters long,
a response file was not created and CreateProcessW was called with
too long command line.

Differential Revision: https://reviews.llvm.org/D83772




More information about the All-commits mailing list