[all-commits] [llvm/llvm-project] ab6263: Revert 502f0cc0e38 "[GWP-ASan] Split the unwinder ...

[Hans via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ab6263c9258ccd0e3c9cb4f675979f22cfba6131
      https://github.com/llvm/llvm-project/commit/ab6263c9258ccd0e3c9cb4f675979f22cfba6131
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M compiler-rt/lib/gwp_asan/optional/backtrace_linux_libc.cpp
    M compiler-rt/lib/gwp_asan/optional/backtrace_sanitizer_common.cpp
    M compiler-rt/lib/gwp_asan/optional/segv_handler.h
    M compiler-rt/lib/gwp_asan/optional/segv_handler_posix.cpp
    M compiler-rt/lib/gwp_asan/tests/CMakeLists.txt
    M compiler-rt/lib/gwp_asan/tests/harness.h
    M compiler-rt/lib/scudo/scudo_allocator.cpp
    M compiler-rt/lib/scudo/standalone/combined.h
    R compiler-rt/test/gwp_asan/backtrace.c

  Log Message:
  -----------
  Revert 502f0cc0e38 "[GWP-ASan] Split the unwinder into segv/non-segv."

It was causing tests to fail in -DCOMPILER_RT_BUILD_BUILTINS=OFF builds:

   GwpAsan-Unittest :: ./GwpAsan-x86_64-Test/BacktraceGuardedPoolAllocator.DoubleFree
   GwpAsan-Unittest :: ./GwpAsan-x86_64-Test/BacktraceGuardedPoolAllocator.UseAfterFree

see comment on the code review.

> Summary:
> Splits the unwinder into a non-segv (for allocation/deallocation traces) and a
> segv unwinder. This ensures that implementations can select an accurate, slower
> unwinder in the segv handler (if they choose to use the GWP-ASan provided one).
> This is important as fast frame-pointer unwinders (like the sanitizer unwinder)
> don't like unwinding through signal handlers.
>
> Reviewers: morehouse, cryptoad
>
> Reviewed By: morehouse, cryptoad
>
> Subscribers: cryptoad, mgorny, eugenis, pcc, #sanitizers
>
> Tags: #sanitizers
>
> Differential Revision: https://reviews.llvm.org/D83994

This reverts commit 502f0cc0e3889229e923e187f38dda91324ae139.