[all-commits] [llvm/llvm-project] 3980e8: [libcxx][lit] Simplify parsing of trailing executo...

[Alexander Richardson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3980e8956b68f229a79194fbd46e4a91abf3aa2e
      https://github.com/llvm/llvm-project/commit/3980e8956b68f229a79194fbd46e4a91abf3aa2e
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M libcxx/utils/run.py
    M libcxx/utils/ssh.py

  Log Message:
  -----------
  [libcxx][lit] Simplify parsing of trailing executor arguments

Adding a positional argparse.ONE_OR_MORE arguments will correctly remove
the "--" separator after --env and parse only the command. This also has
the advantage that misspelled flags raise an argparse error rather than
silently being added to the command to be executed.

I discovered this while adding a new commandline option to ssh.py to allow
passing additional arguments to the scp/ssh commands since this is required
for our CHERI CI where we need to pass `-F <custom_config_file>` to each
ssh/scp command to set various arguments such as the localhost port, usage
of controlmaster, etc. to speed up connections to our emulated QEMU systems.

Reviewed By: #libc, ldionne

Differential Revision: https://reviews.llvm.org/D84096


  Commit: f5d4a58b4a2621674de97ea3f796687eb0810c7f
      https://github.com/llvm/llvm-project/commit/f5d4a58b4a2621674de97ea3f796687eb0810c7f
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M llvm/test/Reduce/remove-args-2.ll

  Log Message:
  -----------
  [NFC] Use FileCheck for llvm-reduce interesness test

This makes the test added in 6187eeb683d8c639282d437e6af585e9b7f9c93e
easier to understand since you no longer have to look at another script
to see if it's doing the right thing.


Compare: https://github.com/llvm/llvm-project/compare/aa84e6e579be...f5d4a58b4a26