[all-commits] [llvm/llvm-project] 2ba7ce: [lldb] Use weak_ptr to hold on to the underlying t...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2ba7ce401e760990abb938c57e48c9d77d1b50de
      https://github.com/llvm/llvm-project/commit/2ba7ce401e760990abb938c57e48c9d77d1b50de
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-07-20 (Mon, 20 Jul 2020)

  Changed paths:
    M lldb/include/lldb/API/SBThreadPlan.h
    M lldb/include/lldb/lldb-forward.h
    M lldb/source/API/SBThreadPlan.cpp

  Log Message:
  -----------
  [lldb] Use weak_ptr to hold on to the underlying thread plan in SBThreadPlan

Use a weak pointer to hold on to the the underlying thread plan in
SBThreadPlan. When the process continues, all the popped ThreadPlans get
discarded, and you can’t reuse them, so you have to create them anew.
Therefore the SBThreadPlan doesn’t need to keep the ThreadPlan alive.

This fixes the cleanup error in TestThreadPlanCommands.py and
TestStepScripted.py caused by the thread plans never being deleted.

Differential revision: https://reviews.llvm.org/D84210